Use architecture filter in audit_rules_privileged_commands #14336
+216
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-cerny
requested review from
Mab879,
matusmarhefka and
vojtapolasek
as code owners
jan-cerny
added
bugfix
ATEX Test ResultsTest artifacts have been submitted to Testing Farm. Results: View Test Results This comment was automatically generated by the ATEX workflow. |
The audit rules should contain filters for the system architecture. If the system is a 64bit system there should be 2 rules that differ in architecture filter - one for 32bit and one for 64bit. This change will make rule `audit_rules_privileged_commands` consistent with specialized rules that use the `audit_rules_privileged_commands` template. Resolves: https://issues.redhat.com/browse/RHEL-142647
Reduce code duplication by extracting similar code to macros.
Collaborator
Author
|
I have rebased this PR on the top of the latest upstream master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The audit rules should contain filters for the system architecture. If the system is a 64bit system there should be 2 rules that differ in architecture filter - one for 32bit and one for 64bit. This change will make rule
audit_rules_privileged_commandsconsistent with specialized rules that use theaudit_rules_privileged_commandstemplate.The commit simplifies OVAL checks by extracting common code to Jinja macros.
Resolves: https://issues.redhat.com/browse/RHEL-142647
Review hints
Run automatus tests on RHEL 10.